由买买提看人间百态

boards

本页内容为未名空间相应帖子的节选和存档,一周内的贴子最多显示50字,超过一周显示500字 访问原贴
Seattle版 - 严肃认真地请教一下code review怎么做的问题
相关主题
Project Manager - Full Time (Bellevue)Technical Program Manager - Content & Services
140 k package -C # / .Net Mobile Music Application Developer160 K base -- Technical architect fulltime opportunity at Redmond
C++ in Seattle80 $ per hour -Required a Lead .Net for 6 months contract in Princeton, NJ
Sr. Software Engineer - Full Time60 $ to 70 $ per hour
QA Analyst - Mobile (6 month contract)60 $ +
求好心人 Microsoft Referral成都手游Startup is looking for talents !!! (转载)
Extreme Digging & Pair Digging(至尊挖掘与配对挖掘)Re: 成都手游Startup is looking for talents !!! (转载)
55 $ + per hour Job Title: SDET II - SGC/ED - RVA恶心的烙印同事 (转载)
相关话题的讨论汇总
话题: code话题: review话题: coding话题: agile话题: process
1 (共1页)
O**o
发帖数: 2071
1
这里大公司的牛人比较多,借问一下哈。
我觉得我需要一个code review process。但是不知道要怎么弄。我曾经有个
consultant, 他给过我一些coding standard and code review check points.
这个coding standard有个二十来页,无非是些naming convention, comments,
javadoc这些个东西,跟当年java.sun.com,现在oracle网站上面的没什么大区别,排
版好看一些而已。
然后这个code review check list, 共80项,号称每个module/web page都要查这80项
。靠,这怎么搞啊?这不是坑姐吗?80项每一项都够查一阵子的。这玩意工作量很大啊
,我觉着比coding工作量还大啊。谁有这么多闲功夫一条一条琢磨啊?我不可能一个
developer写出code陪俩Sr. developers做code review啊。
难道就是走个过场?那负责code review的同志不是很惨?sign off之后那就是责任啊
。再说我确实code有点乱,确实想搞这么个process,不是想走过场的。除了general
coding standard, 还有security standard,跟那个什么OWASP有关。
请问各位牛人,你们公司里都是怎么弄这个的?要预留出多少时间给code review呢?
code review如果发现有问题又怎么处理?
感谢感谢!
===================
附:
从80条里面随手paste几个:
All the variables (member variables, local variables) are initialized. (
Either to some object or null or 0)
Judge whether String.length() / String.getBytes().length() should be
used.
Unnecessary imports are not present.
Check whether it is not a double loop.
d********y
发帖数: 2114
2
amazon上面有本书,code complete。
微软出的,很便宜。
里面说了几种code review形式。
O**o
发帖数: 2071
3
书我还没看过,不过网上的文章看了一些。太理论化。所以想知道现实的公司里面是怎
么操作的。

【在 d********y 的大作中提到】
: amazon上面有本书,code complete。
: 微软出的,很便宜。
: 里面说了几种code review形式。

b********7
发帖数: 12906
4
做多了就都印在脑子里了. 成了习惯, 你随便看看就知道符合不符合要求了.
j*****u
发帖数: 1133
5
我们team在用我manager写的code review tool:http://malevich.codeplex.com/
微软的一些其它team也有在用,觉得挺方便的。
经常某天花在code review上的时间比自己写code还多。
有的人喜欢抠coding style,不过stylecop已经能cover大部分了
也有人喜欢揪comment里的语法错误-_-
different ppl have different styles doing code review...

【在 O**o 的大作中提到】
: 这里大公司的牛人比较多,借问一下哈。
: 我觉得我需要一个code review process。但是不知道要怎么弄。我曾经有个
: consultant, 他给过我一些coding standard and code review check points.
: 这个coding standard有个二十来页,无非是些naming convention, comments,
: javadoc这些个东西,跟当年java.sun.com,现在oracle网站上面的没什么大区别,排
: 版好看一些而已。
: 然后这个code review check list, 共80项,号称每个module/web page都要查这80项
: 。靠,这怎么搞啊?这不是坑姐吗?80项每一项都够查一阵子的。这玩意工作量很大啊
: ,我觉着比coding工作量还大啊。谁有这么多闲功夫一条一条琢磨啊?我不可能一个
: developer写出code陪俩Sr. developers做code review啊。

l*********o
发帖数: 3091
6
code review 没事找事。
f******n
发帖数: 198
7
花在code review上的时间比自己写code还多说明你可以做senior了:)
Based on user studies conducted by our team, the way Microsoft does code
review is actually quite different from most of the other companies. In
addition, companies tend to have different views on the importance of doing
code review; in fact they tend to interpret the term "code review"
differently. We've seen companies doing detailed "code" review on design
specs and pseudo-code without looking at the actual code. We've also seen
companies using tests exclusively to verify code correctness. Then there's a
big community of agile adopters that follow formal code review process
where a presentor, a documentor, a group of participants and a proper
preparation including printed handouts and conference room with projector
are all required. Microsoft teams tend to fall somewhere in between, usually
with a somewhat unique emphasis on code quality, orthogonal to functional
correctness and end-user experience. The so-called "code quality" is usually
tied to long-term code maintainability due to Microsoft's business model of
building several platforms (some of them being open-source ones), but is
also frequently a direct reflection of individual developers' ego of being
an better-than-average coder:). If you're starting a small company, agile
process might give you an easier-to-follow template as a starting point; you
can then adapt and adjust later.
O**o
发帖数: 2071
8
Very interesting. Thanks for sharing.
Actually I AM using Agile. The 'Scrum' approch is what I took. I have
two Agile teams, each having 4 developers. So you mean they cross-
function to review each other's code?

code
In
doing
design
seen
there's a
process

【在 f******n 的大作中提到】
: 花在code review上的时间比自己写code还多说明你可以做senior了:)
: Based on user studies conducted by our team, the way Microsoft does code
: review is actually quite different from most of the other companies. In
: addition, companies tend to have different views on the importance of doing
: code review; in fact they tend to interpret the term "code review"
: differently. We've seen companies doing detailed "code" review on design
: specs and pseudo-code without looking at the actual code. We've also seen
: companies using tests exclusively to verify code correctness. Then there's a
: big community of agile adopters that follow formal code review process
: where a presentor, a documentor, a group of participants and a proper

a*****r
发帖数: 901
9
不要怕流程太复杂,所有的流程都是可以剪裁的
1 (共1页)
相关主题
恶心的烙印同事 (转载)QA Analyst - Mobile (6 month contract)
[合集] @ pls recommend furnace repair求好心人 Microsoft Referral
Garmin 下载map updates的问题Extreme Digging & Pair Digging(至尊挖掘与配对挖掘)
Microsoft contract position: Ops Support Engineers55 $ + per hour Job Title: SDET II - SGC/ED - RVA
Project Manager - Full Time (Bellevue)Technical Program Manager - Content & Services
140 k package -C # / .Net Mobile Music Application Developer160 K base -- Technical architect fulltime opportunity at Redmond
C++ in Seattle80 $ per hour -Required a Lead .Net for 6 months contract in Princeton, NJ
Sr. Software Engineer - Full Time60 $ to 70 $ per hour
相关话题的讨论汇总
话题: code话题: review话题: coding话题: agile话题: process